safe_url_string, canonicalize_url: apply stripping from the URL living standard #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
==========================================
+ Coverage 96.14% 96.16% +0.02%
==========================================
Files 8 8
Lines 493 496 +3
Branches 92 93 +1
==========================================
+ Hits 474 477 +3
Misses 9 9
Partials 10 10
|
kmike
approved these changes
Nov 29, 2022
Member
kmike
left a comment
kmike
left a comment
There was a problem hiding this comment.
Looks good, thanks @Gallaecio!
Would it make sense to update safe_url_string docstring? It's no longer only tabs and newlines which are removed.
wRAR
reviewed
Nov 29, 2022
Member
Author
|
Is 288caae OK? It describes more what the functions should (in my opinion) do than what they actually do. |
wRAR
approved these changes
Nov 29, 2022
kmike
reviewed
Nov 29, 2022
kmike
reviewed
Nov 29, 2022
Member
|
Thanks @Gallaecio! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.