Skip to content

[MRG+2] Update the repo for release #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 26, 2020
Merged

[MRG+2] Update the repo for release #295

merged 12 commits into from
Jun 26, 2020

Conversation

@wdevazelhes
Copy link
Member

@wdevazelhes wdevazelhes commented Jun 26, 2020 •
edited
Loading

This PR paves the way for the new release

  • get rid of deprecations
  • Advertise SCML (including in the README), including a possible "experimental" warning
  • Fix the links to algorithms in doc

terrytangyuan
terrytangyuan approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wdevazelhes wdevazelhes changed the title Update the repo for release [WIP] Update the repo for release Jun 26, 2020
@wdevazelhes
Copy link
Member Author

wdevazelhes commented Jun 26, 2020

Hi all, I just removed the deprecations, added the warning for SCML, and advertised SCML in the README. I just noticed that in the doc when cliking on the name of the algo it does not link to the code page, so I'll try to fix that but you can already review the changes

@wdevazelhes
Copy link
Member Author

wdevazelhes commented Jun 26, 2020

For the bug with the links in the doc, it seems that putting back :ref:`modindex` in the docs parameters makes it work but then we got the pb that was the reason it was removed : see #274
So I don't know what to do for that... maybe we can merge this first and fix the doc in another PR ?

@terrytangyuan
Copy link
Member

terrytangyuan commented Jun 26, 2020 •
edited
Loading

Yes I think we can merge this first.

@wdevazelhes wdevazelhes changed the title [WIP] Update the repo for release [MRG+2] Update the repo for release Jun 26, 2020
@wdevazelhes wdevazelhes merged commit 6f783de into scikit-learn-contrib:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@perimosocordiae perimosocordiae perimosocordiae approved these changes

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@bellet bellet Awaiting requested review from bellet

@nvauquie nvauquie Awaiting requested review from nvauquie

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wdevazelhes @terrytangyuan @perimosocordiae