-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Closed
Labels
Description
We need to address the following API issues raised by @jnothman:
-
fit_sampleis not a great name, as I have argued elsewhere ;) - The fact that
imblearn.pipeline.Pipelinehas a method calledsamplethat fits its constituents (usingfit_sample) rings loud alarm bells. IMO, thesamplemethod should not exist. -
fit_sampleneeds, eventually, to be able to update things other than X and y (e.g. weights).