Skip to content

Fix is_categorical_dtype deprecation #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Fix is_categorical_dtype deprecation #419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions category_encoders/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import pandas as pd
import numpy as np
import sklearn.base
from pandas.core.dtypes.dtypes import CategoricalDtype
from sklearn.base import BaseEstimator, TransformerMixin
from sklearn.exceptions import NotFittedError
from typing import Dict, List, Optional, Union
Expand All @@ -25,7 +26,7 @@ def convert_cols_to_list(cols):
return list(cols)
elif isinstance(cols, tuple):
return list(cols)
elif pd.api.types.is_categorical_dtype(cols):
elif isinstance(cols, CategoricalDtype):
return cols.astype(object).tolist()

return cols
Expand All @@ -47,7 +48,7 @@ def get_obj_cols(df):


def is_category(dtype):
return pd.api.types.is_categorical_dtype(dtype)
return isinstance(dtype, CategoricalDtype)


def convert_inputs(X, y, columns=None, index=None, deep=False):
Expand Down