Forth based ROOT reader (revised) #636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpivarski
reviewed
Jul 1, 2022
jpivarski
reviewed
Jul 1, 2022
jpivarski
reviewed
Jul 1, 2022
jpivarski
reviewed
Jul 1, 2022
jpivarski
reviewed
Jul 1, 2022
Comment on lines
+675
to
+686
| read_member_n.append( | ||
| """ | ||
| forth = False | ||
| forth_obj = None | ||
| fcode_pre = [] | ||
| fcode_post = [] | ||
| temp = None | ||
| if "forth" in context.keys(): | ||
| forth = True | ||
| forth_obj = context["forth"] | ||
| key = forth_obj.get_key()\n""" | ||
| ) |
There was a problem hiding this comment.
I think you don't want to put code into the read_member_n, which is for the memberwise format. (Unless a particular type has memberwise implemented in Python as well.)
jpivarski
reviewed
Jul 1, 2022
jpivarski
reviewed
Jul 1, 2022
jpivarski
reviewed
Jul 1, 2022
jpivarski
approved these changes
Jul 1, 2022
Moelf
pushed a commit
to Moelf/uproot5
that referenced
this pull request
Aug 1, 2022
* put in control flow * revised version works * fixed bug in control flow * added test-file * changes to be made in asArray and model.py * WIP * made changes to support multiple read operations on the same class * array of TrefArrays works * added test for array of trefarray * removes stray import * added some string generation for forth in streamers.py * linting * Added a new helper class and incorporated review suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.