Skip to content

feat: implement segment count_nonzero reducer #3452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2025
Merged

feat: implement segment count_nonzero reducer #3452

merged 2 commits into from
Apr 11, 2025

Conversation

@ianna
Copy link
Collaborator

@ianna ianna commented Apr 11, 2025

No description provided.

pfackeldey
pfackeldey approved these changes Apr 11, 2025
View reviewed changes
Copy link
Collaborator

@pfackeldey pfackeldey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 🎉
(is there somewhere a list of kernels that are missing for the jax backend?)

@ianna
Copy link
Collaborator Author

ianna commented Apr 11, 2025

nice! 🎉 (is there somewhere a list of kernels that are missing for the jax backend?)

Thanks! This PR completes the JAX reducers which were marked as NotImplemented. I don't have such a list, but was planning to open a discussion for that.

@ianna ianna merged commit c4d575f into main Apr 11, 2025
42 checks passed
@ianna ianna deleted the ianna/jax_count_non_zero_reducer branch April 11, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pfackeldey pfackeldey pfackeldey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ianna @pfackeldey