feat(rdb): add benchmarks for instance get, backup get/list, and database list #5125
+1,773
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
rdb
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5125 +/- ##
==========================================
- Coverage 57.45% 57.26% -0.19%
==========================================
Files 309 311 +2
Lines 67327 67545 +218
==========================================
Hits 38683 38683
- Misses 27199 27417 +218
Partials 1445 1445 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jremy42
force-pushed
the
feat/rdb-benchmarks
branch
3 times, most recently
from
42f9347 to
1c79dea
Compare
jremy42
force-pushed
the
feat/rdb-benchmarks
branch
2 times, most recently
from
67d354a to
182f63a
Compare
jremy42
force-pushed
the
feat/rdb-benchmarks
branch
from
182f63a to
8919284
Compare
remyleone
reviewed
Nov 13, 2025
| // | ||
| // To compare performance: | ||
| // | ||
| // benchstat testdata/benchmark.baseline <(CLI_RUN_BENCHMARKS=true go test -bench=. -benchtime=100x .) |
Member
There was a problem hiding this comment.
How can this tool be installed?
| instanceReadyTimeout = 3 * time.Minute | ||
| ) | ||
|
|
||
| func setupBenchmark(b *testing.B) (*scw.Client, core.TestMetadata, func(args []string) any) { |
Member
There was a problem hiding this comment.
Could this be transferred in the acctest package ? It does not seem specific to this particular command
|
|
||
| func newBenchmarkStats() *benchmarkStats { | ||
| return &benchmarkStats{ | ||
| enabled: os.Getenv("CLI_BENCH_TRACE") == "true", |
Member
There was a problem hiding this comment.
I think we need an internal env package similar to what exists in terraform.
jremy42
force-pushed
the
feat/rdb-benchmarks
branch
from
722814d to
8d9e91e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close 4429
Community Note
Relates OR Closes #0000
Release note for CHANGELOG: