Skip to content

Fix #1754: Don't narrow GADTs to lower bounds #3918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 3, 2018
Merged

Fix #1754: Don't narrow GADTs to lower bounds #3918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
09fad43
Make preCheckKinds convention more robust
odersky Jan 25, 2018
6086d78
Reclassify NAMEDARG Tasty tag
odersky Jan 25, 2018
7801c57
Treat wildcard args and pattern type variables the same
odersky Jan 25, 2018
4f24531
Fix #1754: Don't narrow GADTs to lower bounds
odersky Jan 25, 2018
1e91c94
Keep track whether compared types are precise
odersky Jan 25, 2018
2425aaf
Handle approximation state as a parameter to isSubType
odersky Jan 25, 2018
8a1c76e
Make ApproxState a value class
odersky Jan 25, 2018
4697e49
Get rid of isCappable
odersky Jan 25, 2018
2fb548a
Revert to keeping approx as TypeComparer state
odersky Jan 26, 2018
9ea0c8b
Avoid isSubType recursions involving Nothing as upper bound
odersky Jan 26, 2018
bee1ab6
Fix DottyBytecodeTests#efficientTryCases
smarter Feb 1, 2018
b42da43
Fix doc comment
odersky Feb 2, 2018
e07af3f
Fix rebase breakage
odersky Feb 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions compiler/src/dotty/tools/dotc/ast/TreeInfo.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,6 +556,7 @@ trait TypedTreeInfo extends TreeInfo[Type] { self: Trees.Instance[Type] =>
val acc = new TreeAccumulator[List[Symbol]] {
def apply(syms: List[Symbol], tree: Tree)(implicit ctx: Context) = tree match {
case Bind(_, body) => apply(tree.symbol :: syms, body)
case Annotated(tree, id @ Ident(tpnme.BOUNDTYPE_ANNOT)) => apply(id.symbol :: syms, tree)
case _ => foldOver(syms, tree)
}
}
Expand Down
1 change: 1 addition & 0 deletions compiler/src/dotty/tools/dotc/core/StdNames.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ object StdNames {
val INITIALIZER_PREFIX: N = "initial$"
val COMPANION_MODULE_METHOD: N = "companion$module"
val COMPANION_CLASS_METHOD: N = "companion$class"
val BOUNDTYPE_ANNOT: N = "$boundType$"
val QUOTE: N = "'"
val TYPE_QUOTE: N = "type_'"
val TRAIT_SETTER_SEPARATOR: N = str.TRAIT_SETTER_SEPARATOR
Expand Down
Loading