Skip to content

used derived types to type arguments of dependent function type #19838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 1, 2024
Merged

used derived types to type arguments of dependent function type #19838

merged 2 commits into from
Mar 1, 2024

Conversation

@bishabosha
Copy link
Member

@bishabosha bishabosha commented Mar 1, 2024

We don't need to repeat the tree twice, instead derive a type tree from the original tree, and reuse its spans.

fixes #19629

@bishabosha bishabosha requested a review from sjrd March 1, 2024 11:04
@bishabosha bishabosha marked this pull request as ready for review March 1, 2024 11:04
@sjrd sjrd enabled auto-merge March 1, 2024 14:16
@sjrd sjrd merged commit 2cd5721 into scala:main Mar 1, 2024
@sjrd sjrd deleted the fix-i19629 branch March 1, 2024 18:09
@Kordyjan Kordyjan added this to the 3.4.2 milestone Mar 28, 2024
@WojciechMazur WojciechMazur mentioned this pull request Jul 2, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jul 3, 2024
@WojciechMazur
Backport "used derived types to type arguments of dependent function …
0167227 
…type" to LTS (#20970)

Backports #19838 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjrd sjrd sjrd approved these changes

Assignees

@sjrd sjrd

Labels

None yet

Projects

None yet

Milestone

3.4.2

Development

Successfully merging this pull request may close these issues.

Crash in compilation from tasty

3 participants

@bishabosha @sjrd @Kordyjan