Fix problems with cycle checks #19453
Conversation
Several improvements: - Follow opaque aliases as if they were aliases. Otherwise we risk crashing in phases where the `opaque` is dropped and these become regular aliases. - Update the `isInteresting` test to follow more types. Previously the test was too strict so some cycles were missed. - Make -explain-cyclic also explain for cycles detected by this check. Fixes scala#19372
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully: Visit https://dotty-bench.epfl.ch/19453/ to see the changes. Benchmarks is based on merging with main (31f837e) |
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully: Visit https://dotty-bench.epfl.ch/19453/ to see the changes. Benchmarks is based on merging with main (31f837e) |
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully: Visit https://dotty-bench.epfl.ch/19453/ to see the changes. Benchmarks is based on merging with main (31f837e) |
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 1 running. |
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit https://dotty-bench.epfl.ch/19453/ to see the changes. Benchmarks is based on merging with main (2945fd1) |
Backports #19453 to the LTS branch. PR submitted by the release tooling. [skip ci]
4 participants
Several improvements:
opaqueis dropped and these become regular aliases.isInterestingtest to follow more types. Previously the test was too strict so some cycles were missed.Fixes #19372