Reset comparersInUse to zero in ContextState.reset
#18915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
approved these changes
Nov 14, 2023
| def impl()(using Quotes): Expr[Unit] = '{()} | ||
| inline def run(): Unit = ${impl()} | ||
|
|
||
|
|
| sources.clear() | ||
| files.clear() | ||
| comparers.clear() // forces re-evaluation of top and bottom classes in TypeComparer | ||
| comparersInUse = 0 |
Contributor
There was a problem hiding this comment.
For additional context, this needs to be reset because the compilation unit was suspended due to the macro dependency. We need to set it back to 0 each time we restart compilation after the suspension.
| @@ -0,0 +1,3 @@ | |||
| import scala.language.experimental.captureChecking | |||
| val x = run() | |||
|
|
|||
|
|
||
| def impl()(using Quotes): Expr[Unit] = '{()} | ||
| inline def run(): Unit = ${impl()} | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18855
The code in #18855 used to crash the compiler with an out-of-bound access exception. It was because, previously,
ContextState.resetclears thecomparers, the cached pool ofTypeComparers, while keeping the variablecomparersInUseintact. However, thecomparermethod of a context assumescomparershas a size greater than or equal tocomparersInUse. So the invariant is clearly violated here and thus triggers the crash.This PR proposes a straightforward fix. Yet, the reason why only under both macros and cc this code path will be triggered remains to be investigated.