Collect all local class definitions #14528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
added
the
backport:nominated
smarter
reviewed
Feb 21, 2022
| case _: Template => | ||
| for sym <- tree.symbol.owner.info.decls do | ||
| markSymbol(sym) | ||
| super.transform(tree) |
Member
There was a problem hiding this comment.
Why isn't mapOverTree used like in the other cases where we call markSymbol?
Contributor
Author
There was a problem hiding this comment.
No reason. I updated it to use mapOverTree.
Inline accessor was generated correctly and added at the end of the class. Then transforming `bar` the `foo$inline` method was not collected yet. Fixes scala#14373
nicolasstucki
force-pushed
the
fix-#14373
branch
from
e3f107e to
764a905
Compare
smarter
approved these changes
Feb 25, 2022
Kordyjan
removed
the
backport:nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline accessor was generated correctly and added at the end of the class.
Then transforming
barthefoo$inlinemethod was not collected yet.Fixes #14373