Fix Positioned#cloneIn #13627
Merged
Fix Positioned#cloneIn #13627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
approved these changes
Sep 28, 2021
Member
smarter
left a comment
smarter
left a comment
There was a problem hiding this comment.
LGTM, but could you squash the two commits together? Having the functional changes and the tests in the same commit makes it easier to tell what a change is for when stumbling upon it via git blame for example.
mbovel
force-pushed
the
mb/slice-position
branch
from
a536ef0 to
e6ffc0d
Compare
Member
|
One more nitpick: descriptive commit messages are nicer, so consider using a commit title like "Fix Positioned#cloneIn to also update the source" instead of "Fix #13626" (and move the "fix #..." in the commit message body), I think you said this fixes a regression, so you could also mention the commit where the regression was introduced in your commit message. |
mbovel
force-pushed
the
mb/slice-position
branch
from
e6ffc0d to
d717d9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13626.