Skip to content

Conversation

@philwalk
Copy link
Contributor

@philwalk philwalk commented Jun 30, 2021

  • Verify return value of call to which("scalac") before attempting test. Same for which("scala").
  • added execute permission to compiler/test-resources/scripting/showArgs.sc

This test may be brittle in that it assumes that the target scalac is in the PATH, or at least that no other version is in the PATH.

Fixes #12962

@dwijnand dwijnand changed the title fix-for-#12962 Fix scripts tests Jun 30, 2021
@dwijnand
Copy link
Member

Rather than using which, could we switch this to dist/bin/scalac and dist/bin/scala and let the test fail if those aren't there or aren't executable?

@philwalk
Copy link
Contributor Author

Rather than using which, could we switch this to dist/bin/scalac and dist/bin/scala and let the test fail if those aren't there or aren't executable?

I will investigate, sounds reasonable.

Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@dwijnand dwijnand merged commit 270bd8b into scala:master Jul 5, 2021
@philwalk philwalk deleted the fix-scripts-tests branch July 5, 2021 16:41
@philwalk philwalk restored the fix-scripts-tests branch July 6, 2021 13:44
@philwalk philwalk deleted the fix-scripts-tests branch July 6, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dotty.tools.scripting.BashScriptsTests are not running properly, but tests are succeeding

2 participants