Skip to content

Fix return type of FetchEvent.preloadResponse #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Fix return type of FetchEvent.preloadResponse #494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api-reports/2_12.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -984,7 +984,7 @@ experimental/serviceworkers/ExtendableMessageEventInit[JT] var scoped: js.UndefO
experimental/serviceworkers/ExtendableMessageEventInit[JT] var source: js.UndefOr[Client | ServiceWorker | MessagePort]
experimental/serviceworkers/FetchEvent[SC] def clientId: String
experimental/serviceworkers/FetchEvent[SC] def isReload: Boolean
experimental/serviceworkers/FetchEvent[SC] def preloadResponse: js.Promise[Response]
experimental/serviceworkers/FetchEvent[SC] def preloadResponse: js.Promise[js.UndefOr[Response]]
experimental/serviceworkers/FetchEvent[SC] def replacesClientId: String
experimental/serviceworkers/FetchEvent[SC] def request: Request
experimental/serviceworkers/FetchEvent[SC] def respondWith(promisedResponse: Response | js.Promise[Response]): Unit
Expand Down
2 changes: 1 addition & 1 deletion api-reports/2_13.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -984,7 +984,7 @@ experimental/serviceworkers/ExtendableMessageEventInit[JT] var scoped: js.UndefO
experimental/serviceworkers/ExtendableMessageEventInit[JT] var source: js.UndefOr[Client | ServiceWorker | MessagePort]
experimental/serviceworkers/FetchEvent[SC] def clientId: String
experimental/serviceworkers/FetchEvent[SC] def isReload: Boolean
experimental/serviceworkers/FetchEvent[SC] def preloadResponse: js.Promise[Response]
experimental/serviceworkers/FetchEvent[SC] def preloadResponse: js.Promise[js.UndefOr[Response]]
experimental/serviceworkers/FetchEvent[SC] def replacesClientId: String
experimental/serviceworkers/FetchEvent[SC] def request: Request
experimental/serviceworkers/FetchEvent[SC] def respondWith(promisedResponse: Response | js.Promise[Response]): Unit
Expand Down
2 changes: 1 addition & 1 deletion src/main/scala/org/scalajs/dom/experimental/serviceworkers/ServiceWorkers.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ class FetchEvent(typeArg: String, init: js.UndefOr[FetchEventInit])
*/
def request: Request = js.native

def preloadResponse: js.Promise[Response] = js.native
def preloadResponse: js.Promise[js.UndefOr[Response]] = js.native

def clientId: String = js.native

Expand Down