fix: Enable libsass 2914 #1420
Merged
fix: Enable libsass 2914 #1420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschonni
force-pushed
the
fix--Enable-libsass-2914
branch
from
f0c26ce to
9daa74f
Compare
nex3
requested changes
Jul 1, 2019
There was a problem hiding this comment.
When you're making a spec PR that depends on LibSass changes, please add "[skip libsass]" to the PR description. This will tell Travis not to run tests against LibSass. Similarly, the LibSass PR description should include "See #1420" to tell LibSass to run specs against this PR, which verifies that your change does in fact fix these specs.
|
@nex3 the upstream PR landed now, if you want to clear the changes requested |
|
I'm landing this even though Travis is red because multiple changes (including this one) were landed in LibSass at once, so we need to land multiple fixes at once to get everything green again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on sass/libsass#2933