Add tests for arithmetic edge case #1228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgreter
force-pushed
the
arithmetic-edge-cases
branch
from
e6d69ec to
7af3876
Compare
nex3
reviewed
Mar 15, 2018
| s: (5em / 2); | ||
| t: 1 + (2 + (3/4 + (4/5 6/7))); | ||
| u: (1 / 0); // Infinity | ||
| v: (0 / 0); // NaN |
There was a problem hiding this comment.
I'd really like to move to more self-descriptive test cases, rather than ones that are labeled arbitrarily using numbers or letters. For example, these could be written
one-over-zero: (1 / 0);
zero-over-zero: (0 / 0);This makes it easier to tell what the test cases is when looking up the expected output, and in more complex cases to determine what the point of the test is.
| t: 1 + (2 + (3/4 + (4/5 6/7))); | ||
| u: (1 / 0); // Infinity | ||
| v: (0 / 0); // NaN | ||
| } |
There was a problem hiding this comment.
I don't understand why these test cases were added to a directory called "arithmetic and lists" when they don't seem to have anything to do with lists.
nex3
added a commit
that referenced
this pull request
Mar 15, 2018
To match the behavior of dividing by zero, this should produce NaN rather than failing. See also #1228
Merged
nex3
added a commit
that referenced
this pull request
Mar 16, 2018
To match the behavior of dividing by zero, this should produce NaN rather than failing. See also #1228
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.