feat: make source required in core #642
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Sep 25, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
judofyr
force-pushed
the
holm/document-source
branch
from
1646132 to
e51e7af
Compare
judofyr
force-pushed
the
holm/source-required
branch
from
4ff74b6 to
63f37d9
Compare
judofyr
force-pushed
the
holm/source-required
branch
from
63f37d9 to
dd9d259
Compare
judofyr
force-pushed
the
holm/document-source
branch
from
e51e7af to
d94d519
Compare
judofyr
force-pushed
the
holm/document-source
branch
from
d94d519 to
d06408d
Compare
judofyr
force-pushed
the
holm/source-required
branch
from
dd9d259 to
7e31fe0
Compare
This modifies the `bindActionByDataset` function to _require_ source to be passed and _only_ supports that. This now completes the work of: 1. Decoupling these methods from SanityInstance. These now don't look at the SanityInstance config to determine what to do. 2. Opening up for supporting other types of sources now that everything is encapsulated in DocumentSource.
judofyr
force-pushed
the
holm/source-required
branch
from
7e31fe0 to
2d74286
Compare
judofyr
force-pushed
the
holm/document-source
branch
from
d06408d to
4ef7a92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What to review
Testing
Fun gif