Skip to content
This repository was archived by the owner on Oct 24, 2025. It is now read-only.

Conversation

@WesleyTran0
Copy link
Contributor

Purpose

  • Giving us more access on what terms are 'active'
  • Notifications will only be added if they are for an 'active' class

Tickets

#281

Contributors

@WesleyTran0

Feature List

  • Added activeTerms list of strings to macro. This will be manually changed until further notice
  • updater now only updates active terms. Every previous call to 'getActiveTerms' are now replaced with the recently added macros.activeTermIds
  • active field is now added to termId in graphQL endpoints. This feature is reflected on the front end as well (will be mentioned in another PR to the frontend)
  • prevents subscriptions to classes that aren't a part of any active terms. Filters out both section and course lists and if there are no classes to add to subscriptions after the filtering, return with a code of 204 rather than just returning 200 (may be confusing)

Notes (Optional)

Will be connected to another PR to the front end to make the graphQL endpoint for active field accessibile on the front end

Reviewers

Primary reviewer:

Primary: @mehallhm

Secondary reviewers:

Secondary: @cherman23 @ItsEricSun @nickpfeiffer05 @ananyaspatil

@WesleyTran0 WesleyTran0 requested a review from mehallhm April 2, 2025 02:41
@WesleyTran0 WesleyTran0 self-assigned this Apr 2, 2025
@WesleyTran0
Copy link
Contributor Author

Connected with the PR #337 in searchneu

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants