Fix #2799 -- drop recommendation of polyfill.io #2800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The polyfill.io domain is shut down due to the reports of a malicious activity It is better to not recommend/promote it Refs: - https://snyk.io/blog/polyfill-supply-chain-attack-js-cdn-assets/ - https://www.sonatype.com/blog/polyfill.io-supply-chain-attack-hits-100000-websites-all-you-need-to-know
friday
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
👍 I just came to check about this since I remember we used to recommend this cdn heavily.
@sampotts I know plyr is unsupported now, but I think it'd be wise to get this one merged.
The domain registrar deactivated the domain, so the risk is currently zero, and Codepen have replaced the unsafe links in the examples we have referenced with links to Cloudflares safe self-hosted variant. So the only thing to fix I think is merging this PR (the plyr.io demo doesn't use the polyfill cdn).
|
I didn't know I still had the access to merge :D |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The polyfill.io domain is shut down due to the reports of a malicious activity
It is better to not recommend/promote it
Refs: