fix angular universal #1631
Open
fix angular universal #1631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampotts
reviewed
Jan 13, 2020
Comment on lines
+8
to
+9
| "module": "dist/plyr.min.js", | ||
| "jsnext:main": "dist/plyr.min.js", |
There was a problem hiding this comment.
What's the reason behind this? This will use the ES5 code.
|
I am also facing the same issue using plyr with Angular Universal and would really appreciate this pull request being merged. |
Sure, just waiting on my comment getting an answer. Currently it'll potentially cause other issues if I merge it. |
|
Can someone check this solution and merge it because right now Plyr is not working on Angular Universal 14... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1443