feat: configure LDP server with certificate + some cleanup #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maliroteh-sf
commented
Jun 25, 2024
maliroteh-sf
commented
Jun 25, 2024
khawkins
reviewed
Jun 25, 2024
khawkins
reviewed
Jun 25, 2024
khawkins
reviewed
Jun 25, 2024
khawkins
reviewed
Jun 25, 2024
khawkins
reviewed
Jun 25, 2024
khawkins
reviewed
Jun 26, 2024
khawkins
reviewed
Jun 26, 2024
Collaborator
khawkins
left a comment
khawkins
left a comment
There was a problem hiding this comment.
I think, other than the outstanding certificate discussions, this looks good to me.
maliroteh-sf
commented
Jun 26, 2024
khawkins
reviewed
Jun 28, 2024
khawkins
reviewed
Jun 28, 2024
khawkins
reviewed
Jun 28, 2024
Collaborator
khawkins
left a comment
khawkins
left a comment
There was a problem hiding this comment.
The changes look good to me overall. Just the question of binary cert data (which you have in progress) and the configuration of the port.
Co-authored-by: moorejacqueline <[email protected]>
Co-authored-by: moorejacqueline <[email protected]>
khawkins
reviewed
Jun 28, 2024
src/shared/previewUtils.ts
Outdated
| // If we have not previously generated the cert files then go ahead and do so | ||
| if (!fs.existsSync(targetFile)) { | ||
| if (platform === Platform.ios) { | ||
| fs.writeFileSync(targetFile, data.derCertificate, { encoding: 'binary' }); |
Collaborator
There was a problem hiding this comment.
So here I'd drop the options specifying encoding, because that's an inherently textual configuration, and doesn't apply to a raw Buffer.
khawkins
approved these changes
Jun 28, 2024
Collaborator
khawkins
left a comment
khawkins
left a comment
There was a problem hiding this comment.
Just the minor comment around saving the DER file, but otherwise this looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
@W-15906501@