feat: add custom config variables for dev server #67
Conversation
Co-authored-by: Abdulsattar Mohammed <[email protected]>
| const ldpServerUrl = PreviewUtils.generateWebSocketUrlForLocalDevServer(platform, '8081'); | ||
| const ldpServerUrl = PreviewUtils.generateWebSocketUrlForLocalDevServer( | ||
| platform, | ||
| `${await LwcDevServerUtils.getLocalDevServerPort()}` |
There was a problem hiding this comment.
@maliroteh-sf not sure why the port is consumed as a string?
There was a problem hiding this comment.
I have this fixed locally so please ignore for now until my next PR.
| /** | ||
| * The port number of the local dev server. | ||
| */ | ||
| LOCAL_DEV_SERVER_PORT = 'local-dev-server-port', |
There was a problem hiding this comment.
we can /bike-shed on the name since this variable is public
| const ldpServerUrl = PreviewUtils.generateWebSocketUrlForLocalDevServer(platform, '8081'); | ||
| const ldpServerUrl = PreviewUtils.generateWebSocketUrlForLocalDevServer( | ||
| platform, | ||
| `${await LwcDevServerUtils.getLocalDevServerPort()}` |
There was a problem hiding this comment.
I have this fixed locally so please ignore for now until my next PR.
| export const LOCAL_DEV_SERVER_DEFAULT_PORT = 8081; | ||
| export const LOCAL_DEV_SERVER_DEFAULT_WORKSPACE = Workspace.SfCli; | ||
|
|
||
| export class LwcDevServerUtils { |
There was a problem hiding this comment.
FYI, I plan on consolidating lwcDevServerUtils.ts and identityUtils.ts into configUtils.ts since the code in both of these are around fetching or writing different config values. But as far as this PR is concerned, we can leave this unchanged.
There was a problem hiding this comment.
yeah I realized that we are wasting at least next tick since we are loading the same config twice.
What does this PR do?
Adds config variables to customize lwc-dev-server
To be merged after #52
What issues does this PR fix or reference?