Skip to content

fix: set node version for npm-publish @W-16974485@ #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 6, 2024
Merged

fix: set node version for npm-publish @W-16974485@ #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
829c9a5
fix: customize CI for node v20 @W-16974485@
ravijayaramappa Nov 4, 2024
38a9519
fix: add debug logs to figure out npm tag issue @W-16974485@ (#236)
ravijayaramappa Nov 4, 2024
3df9681
fix: set node version for npm-publish @W-16974485@ (#241)
ravijayaramappa Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/onRelease.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ jobs:
ref: ${{ github.event.release.tag_name || inputs.tag }}
- uses: salesforcecli/github-workflows/.github/actions/getPreReleaseTag@main
id: distTag
- run: echo "[INFO] tag is=$INPUTS_TAG , version is=$INPUTS_VERSION"
env:
INPUTS_TAG: ${{ steps.distTag.outputs.tag }}
INPUTS_VERSION: ${{ steps.distTag.outputs.version }}

getMajorVersion:
needs: [getDistTag]
Expand All @@ -30,8 +34,12 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: salesforcecli/github-workflows/.github/actions/parse-semver@main
id: parsedVersion
with:
input_string: ${{ needs.getDistTag.outputs.version }}
- run: echo "[INFO] Major version is=$INPUTS_MAJOR_VERSION"
env:
INPUTS_MAJOR_VERSION: ${{ steps.parsedVersion.outputs.major }}

npm:
uses: salesforcecli/github-workflows/.github/workflows/npmPublish.yml@main
Expand All @@ -41,5 +49,6 @@ jobs:
sign: true
tag: ${{ needs.getDistTag.outputs.tag || (needs.getMajorVersion.outputs.major == '1') && 'latest' || 'next' }}
githubTag: ${{ github.event.release.tag_name || inputs.tag }}
nodeVersion: 20.18.0

secrets: inherit
3 changes: 2 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: tests
on:
push:
branches-ignore: [main]
branches-ignore: [main, 252-patch]
workflow_dispatch:

jobs:
Expand All @@ -26,3 +26,4 @@ jobs:
fail-fast: false
with:
os: ${{ matrix.os }}
nodeVersion: 20.18.0
2 changes: 1 addition & 1 deletion .github/workflows/validate-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
pull_request:
types: [opened, reopened, edited]
# only applies to PRs that want to merge to main
branches: [main]
branches: [main, 252-patch]

jobs:
pr-validation:
Expand Down
Loading