Skip to content

remove old-style _coerce_impl in abvar/ #41087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
+9 −18
Merged

remove old-style _coerce_impl in abvar/ #41087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 9 additions & 18 deletions src/sage/modular/abvar/homspace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,15 @@
sage: T.index_in_saturation()
1

TESTS::

sage: J = J0(37) ; J.Hom(J)(matrix(ZZ,4,[5..20]))
Abelian variety endomorphism of Abelian variety J0(37) of dimension 2
sage: K = J0(11) * J0(11) ; J.Hom(K)(matrix(ZZ,4,[5..20]))
Abelian variety morphism:
From: Abelian variety J0(37) of dimension 2
To: Abelian variety J0(11) x J0(11) of dimension 2

AUTHORS:

- William Stein (2007-03)
Expand Down Expand Up @@ -363,24 +372,6 @@ def __call__(self, M, **kwds):
raise TypeError("can only coerce in matrices or morphisms")
return self.element_class(self, M, side)

def _coerce_impl(self, x):
"""
Coerce x into self, if possible.

EXAMPLES::

sage: J = J0(37) ; J.Hom(J)._coerce_impl(matrix(ZZ,4,[5..20]))
Abelian variety endomorphism of Abelian variety J0(37) of dimension 2
sage: K = J0(11) * J0(11) ; J.Hom(K)._coerce_impl(matrix(ZZ,4,[5..20]))
Abelian variety morphism:
From: Abelian variety J0(37) of dimension 2
To: Abelian variety J0(11) x J0(11) of dimension 2
"""
if self.matrix_space().has_coerce_map_from(parent(x)):
return self(x)
else:
return HomsetWithBase._coerce_impl(self, x)

def _repr_(self):
"""
String representation of a modular abelian variety homspace.
Expand Down
Loading