Fixed doc_test in database.findstat by adding new collection
#36991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit fa606f3; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 5, 2024
… collection This pull request addresses the doctest failures reported when testing the `findstat` module. The failures are related to the addition of a new collection, causing discrepancies in the expected and actual results. The doctest failures were observed with the following optional packages: ``` --optional=4ti2,antic,build,cbc,ccache,cryptominisat,debian,dot2tex,e_an tic,external,fricas,glucose,kissat,latte_int,lidia,normaliz,pip,sage,sag e_numerical_backends_coin,sage_spkg ``` I have updated the doctests to include the new collection in the expected results. Fixes sagemath#36481 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#36991 Reported by: Aman Moon Reviewer(s): Martin Rubey
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2024
sagemathgh-36991: Fixed doc_test in `database.findstat` by adding new collection This pull request addresses the doctest failures reported when testing the `findstat` module. The failures are related to the addition of a new collection, causing discrepancies in the expected and actual results. The doctest failures were observed with the following optional packages: ``` --optional=4ti2,antic,build,cbc,ccache,cryptominisat,debian,dot2tex,e_an tic,external,fricas,glucose,kissat,latte_int,lidia,normaliz,pip,sage,sag e_numerical_backends_coin,sage_spkg ``` I have updated the doctests to include the new collection in the expected results. Fixes sagemath#36481 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#36991 Reported by: Aman Moon Reviewer(s): Martin Rubey
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2024
sagemathgh-36991: Fixed doc_test in `database.findstat` by adding new collection This pull request addresses the doctest failures reported when testing the `findstat` module. The failures are related to the addition of a new collection, causing discrepancies in the expected and actual results. The doctest failures were observed with the following optional packages: ``` --optional=4ti2,antic,build,cbc,ccache,cryptominisat,debian,dot2tex,e_an tic,external,fricas,glucose,kissat,latte_int,lidia,normaliz,pip,sage,sag e_numerical_backends_coin,sage_spkg ``` I have updated the doctests to include the new collection in the expected results. Fixes sagemath#36481 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#36991 Reported by: Aman Moon Reviewer(s): Martin Rubey
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2024
sagemathgh-36991: Fixed doc_test in `database.findstat` by adding new collection This pull request addresses the doctest failures reported when testing the `findstat` module. The failures are related to the addition of a new collection, causing discrepancies in the expected and actual results. The doctest failures were observed with the following optional packages: ``` --optional=4ti2,antic,build,cbc,ccache,cryptominisat,debian,dot2tex,e_an tic,external,fricas,glucose,kissat,latte_int,lidia,normaliz,pip,sage,sag e_numerical_backends_coin,sage_spkg ``` I have updated the doctests to include the new collection in the expected results. Fixes sagemath#36481 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#36991 Reported by: Aman Moon Reviewer(s): Martin Rubey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the doctest failures reported when testing the
findstatmodule. The failures are related to the addition of a new collection, causing discrepancies in the expected and actual results.The doctest failures were observed with the following optional packages:
I have updated the doctests to include the new collection in the expected results.
Fixes #36481
📝 Checklist