Skip to content

Conversation

fchapoton
Copy link
Contributor

fixing a few details in C-finite sequences

main change : use Parent (new coercion framework) instead of Ring

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

Copy link

Documentation preview for this PR (built with commit 48457d2; changes) is ready! 🎉

Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 21, 2023
fixing a few details in C-finite sequences

main change : use `Parent` (new coercion framework) instead of `Ring`

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.

URL: sagemath#36934
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 22, 2023
sagemathgh-36934: details fixed in cfinite_sequence.py
    
fixing a few details in C-finite sequences

main change : use `Parent` (new coercion framework) instead of `Ring`

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#36934
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 23, 2023
sagemathgh-36934: details fixed in cfinite_sequence.py
    
fixing a few details in C-finite sequences

main change : use `Parent` (new coercion framework) instead of `Ring`

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#36934
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 24, 2023
sagemathgh-36934: details fixed in cfinite_sequence.py
    
fixing a few details in C-finite sequences

main change : use `Parent` (new coercion framework) instead of `Ring`

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#36934
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 25, 2023
fixing a few details in C-finite sequences

main change : use `Parent` (new coercion framework) instead of `Ring`

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.

URL: sagemath#36934
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe
@vbraun vbraun merged commit 5161665 into sagemath:develop Dec 26, 2023
@fchapoton fchapoton deleted the details_cfinite_seq branch December 26, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants