pass algorithm argument to custom numeric evaluation methods

[burcin]

Custom numeric evaluation functions defined in the _evalf_() method of symbolic functions accept only the parent of the result as an argument. We should expand this to allow passing an algorithm parameter as well.

Merge together with dependencies (i.e. there are circular dependencies).

Depends on #13933
Depends on #4102
Depends on #15198

CC: @benjaminfjones @sagetrac-dsm @kcrisman @kini @eviatarbach @vbraun

Component: symbolics

Keywords: pynac sd35.5 sd40.5 sd48

Author: Burcin Erocal, Benjamin Jones

Branch: ef6d2de

Reviewer: Karl-Dieter Crisman, Douglas MacNeil, Benjamin Jones, Jean-Pierre Flori

Issue created by migration from https://trac.sagemath.org/ticket/12289

[burcin]

Attachment: trac_12289-evalf_dictionary.patch.gz

[burcin]

Attachment: trac_12289-add_algorithm_arg.patch.gz

Attachment: trac_12289-example.patch.gz

[burcin]

comment:1

The evalf_dict branch of Pynac available here, with the attached patches applied to the Sage library, allows this:

sage: cot(1/2).n(algorithm='foo')
11.0000000000000
sage: cot(1/2).n()
1.83048772171245

The docstrings for _convert() etc. methods of symbolic expressions need to be updated to reflect these changes.

[benjaminfjones]

comment:2

I'm doing some testing of these patches along with rebasing #1173. Thanks Burcin!

[benjaminfjones]

Changed keywords from pynac to pynac sd35.5

[benjaminfjones]

Changed keywords from pynac sd35.5 to pynac sd35.5 sd40.5

[benjaminfjones]

comment:4

I'm trying to rebase the patch attachment: trac_12289-evalf_dictionary.patch to sage-5.0, but I'm running into a problem with the type of py_funcs.py_float. In the patch py_float has type object (*)(object, object) but in sage-5.0, it has type object (*)(object, PyObject *) I guess because of a pynac change in the meantime.

To be more specific, with this type def for py_float:

cdef public object py_float(object n, object kwds) except +:

I rebuild sage and get:

Error compiling Cython file:
------------------------------------------------------------
...
    py_funcs.py_is_prime = &py_is_prime

    py_funcs.py_integer_from_long = &py_integer_from_long
    py_funcs.py_integer_from_python_obj = &py_integer_from_python_obj
    
    py_funcs.py_float = &py_float
                       ^
------------------------------------------------------------

sage/symbolic/pynac.pyx:2040:24: Cannot assign type 'object (*)(object, object)' to 'object (*)(object, PyObject *)'

Any suggestions (burcin?)

[benjaminfjones]

Attachment: trac_12289-evalf_dictionary_rebase.patch.gz

rebase to sage-5.0 + pynac-0.2.4 spkg

[benjaminfjones]

Attachment: trac_12289_py_float_fix.patch.gz

fix py_float delcaration

[benjaminfjones]

comment:7

I've been working on this ticket today at sd40.5. I've got burcin's changes working in sage-5.0 with a caveat. Here's how to get the example in comment:1 working in sage-5.0:

1. install the __patched__ pynac-0.2.4.p1 spkg at http://sage.math.washington.edu/home/bjones/pynac-0.2.4.p1.spkg. this spkg is the pynac-0.2.4 spkg from update to Pynac 0.2.4 #12950 which has been patched to include the changes from burcin's pynac-wip branch of pynac mentioned above.

2. apply all patches at update to Pynac 0.2.4 #12950, here is a shell script to help that (run from $SAGE_ROOT/devel/sage): http://sage.math.washington.edu/home/bjones/trac_12950_apply.sh

3. apply the patches to $SAGE_ROOT/devel/sage

   • attachment: trac_12289-evalf_dictionary_rebase.patch
   • attachment: trac_12289-add_algorithm_arg.patch
   • attachment: trac_12289-example.patch
   • attachment: trac_12289_py_float_fix.patch (fixes the problem I had in comment:4)

4. sage -b