Add advisory for borrowck_sacrifices uninitialized memory #2433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safe function any_as_u8_slice exposes uninitialized padding bytes. Fixed in 0.2.0.
|
Hi @alexpyattaev, Could you please confirm you're okay with publishing this advisory for the soundness issue alexpyattaev/borrowck_sacrifices#1? Thanks! |
|
Not sure it warrants a RUSTSEC entry but no objections either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an advisory for a soundness issue in borrowck_sacrifices.
Summary
The safe function
any_as_u8_sliceexposes uninitialized memory when used with types containing padding bytes.Details
&[u8]including uninitialized padding bytes viafrom_raw_partsfrom_raw_parts, causing undefined behavior