Skip to content

Attempt to fix occasional CI client/server test flakes. #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Attempt to fix occasional CI client/server test flakes. #343

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f67919
tests: fix wait_tcp_port format string.
cpu Aug 16, 2023
bc5b29f
tests: wait for tcp port for all test types.
cpu Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/client-server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def wait_tcp_port(host, port):
else:
print("client-server.py: unable to connect")
sys.exit(1)
print("client-server.py: detected server is up on {host}:{port}")
print(f"client-server.py: detected server is up on {host}:{port}")

class Failure(Exception):
pass
Expand Down Expand Up @@ -219,6 +219,7 @@ def main():
server_popen = run_server(server, valgrind, {
"AUTH_CERT": "testdata/minica.pem",
})
wait_tcp_port(HOST, PORT)
run_mtls_client_tests(client, valgrind)
server_popen.kill()
server_popen.wait()
Expand All @@ -228,6 +229,7 @@ def main():
"AUTH_CERT": "testdata/minica.pem",
"AUTH_CRL": "testdata/test.crl.pem",
})
wait_tcp_port(HOST, PORT)
run_mtls_client_crl_tests(client, valgrind)


Expand Down