Add workflow for clippy #1364
Add workflow for clippy #1364
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
| cargo clippy | ||
| --all-features | ||
| --message-format=json | clippy-sarif | tee rust-clippy-results.sarif | sarif-fmt |
There was a problem hiding this comment.
If I understand correctly, this will check the rand and rand_core (a dependency), but not other crates.
Maybe use --all (but then --all-features does not apply correctly to other crates) or --no-deps and check each crate separately.
|
It seems there are a bunch of deprecation warnings... This is a bit frustrating, since this is the file that GitHub currently suggests... 😅 |
|
In my experience it's better to use a fixed toolchain version for a Clippy job and bump it from time to time manually. Otherwise, on new stable release we may get unrelated CI failures in PRs. |
|
#1448 has added a Clippy workflow, so I think we can close this PR? |
No description provided.