Add back empty slice check #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#291 inadvertantly removed this check See #104 for why this was added in the first place. Also, per our docs: > If `dest` is empty, `getrandom` immediately returns success, making > no calls to the underlying operating system. Signed-off-by: Joe Richey <[email protected]>
newpavlov
approved these changes
Oct 21, 2022
briansmith
added a commit
to briansmith/getrandom
that referenced
this pull request
Oct 21, 2022
Modify the custom tests so that they would have detected and prevented the issue fixed in rust-random#298.
briansmith
added a commit
to briansmith/getrandom
that referenced
this pull request
Oct 21, 2022
Modify the custom tests so that they would have detected and prevented the issue fixed in rust-random#298.
briansmith
added a commit
to briansmith/getrandom
that referenced
this pull request
Oct 21, 2022
Modify the custom tests so that they would have detected and prevented the issue fixed in rust-random#298.
briansmith
added a commit
to briansmith/getrandom
that referenced
this pull request
Oct 21, 2022
Modify the custom tests so that they would have detected and prevented the issue fixed in rust-random#298.
briansmith
added a commit
to briansmith/getrandom
that referenced
this pull request
Oct 21, 2022
Modify the custom tests so that they would have detected and prevented the issue fixed in rust-random#298.
josephlr
pushed a commit
that referenced
this pull request
Oct 22, 2022
Modify the custom tests so that they would have detected and prevented the issue fixed in #298.
josephlr
pushed a commit
to josephlr/getrandom
that referenced
this pull request
Oct 22, 2022
Modify the custom tests so that they would have detected and prevented the issue fixed in rust-random#298.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#291 inadvertantly removed this check
See #104 for why this was added in the first place. Also, per our docs:
Signed-off-by: Joe Richey [email protected]