Skip to content

Remove dead_code workarounds #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2024
Merged

Remove dead_code workarounds #1302

merged 1 commit into from
Aug 9, 2024

Conversation

nicholasbishop
Copy link
Member

The changes to dead_code analysis that lead to unwanted warnings have been reverted for now in rustc.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@nicholasbishop
Remove dead_code workarounds
0ab6973 
The changes to dead_code analysis that lead to unwanted warnings have been
reverted for now in rustc.
@phip1611 phip1611 added this pull request to the merge queue Aug 9, 2024
@phip1611
Copy link
Member

phip1611 commented Aug 9, 2024

Great

Merged via the queue into rust-osdev:main with commit 60a4934 Aug 9, 2024
13 checks passed
@nicholasbishop nicholasbishop deleted the bishop-dead-code-good branch August 9, 2024 15:24
@nicholasbishop nicholasbishop mentioned this pull request Aug 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholasbishop @phip1611