Skip to content

Conversation

@nicholasbishop
Copy link
Member

One minor implementation change from the BootServices version: the Status value is ignored rather than asserting it is SUCCESS. There shouldn't be any practical difference, as stalling should always succeed. In the unlikely event that some implementation returns an error, a panic is unlikely to be desirable to the caller.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

One minor implementation change from the BootServices version: the Status value
is ignored rather than asserting it is `SUCCESS`. There shouldn't be any
practical difference, as stalling should always succeed. In the unlikely event
that some implementation returns an error, a panic is unlikely to be desirable
to the caller.
@phip1611 phip1611 added this pull request to the merge queue Aug 7, 2024
Merged via the queue into rust-osdev:main with commit c52c71e Aug 7, 2024
@nicholasbishop nicholasbishop deleted the bishop-boot-stall branch August 7, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants