[Misc] Add ResetNotification protocol. Add Misc to uefi-test-runner. #1116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
reviewed
Apr 5, 2024
phip1611
reviewed
Apr 5, 2024
phip1611
reviewed
Apr 5, 2024
phip1611
reviewed
Apr 5, 2024
uefi-test-runner/src/proto/misc.rs
Outdated
| } | ||
|
|
||
|
|
||
| pub fn test_reset_notification(image: Handle, bt: &BootServices) { |
Member
There was a problem hiding this comment.
nit: This only tests to set hook but not that the hook is actually called. Can we fix/add that?
Member
|
Thanks for the contribution! I left some nits and questions Please fix the CI, i.e., run |
nicholasbishop
approved these changes
Apr 20, 2024
Member
nicholasbishop
left a comment
nicholasbishop
left a comment
There was a problem hiding this comment.
Lgtm, thanks for the PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I has add the ResetNotification protocol in Misc, and Add Misc with Timestamp and ResetNotification protocol to uefi-test-runner.
Checklist