intrinsic-test: streamline c compilation
#1861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
reviewed
Jul 10, 2025
folkertdev
changed the title
intrinsic-test: streamline c compilation
folkertdev
force-pushed
the
streamline-c-compilation
branch
from
d2a815e to
e8d5bc4
Compare
folkertdev
commented
Jul 12, 2025
Comment on lines
35
to
47
| cpp_compiler.command_mut().args([ | ||
| &format!("--sysroot={cxx_toolchain_dir}/aarch64_be-none-linux-gnu/libc"), | ||
| "--include-directory", | ||
| &format!("{cxx_toolchain_dir}/aarch64_be-none-linux-gnu/include/c++/14.2.1"), | ||
| "--include-directory", | ||
| &format!("{cxx_toolchain_dir}/aarch64_be-none-linux-gnu/include/c++/14.2.1/aarch64_be-none-linux-gnu"), | ||
| "-L", | ||
| &format!("{cxx_toolchain_dir}/lib/gcc/aarch64_be-none-linux-gnu/14.2.1"), | ||
| "-L", | ||
| &format!("{cxx_toolchain_dir}/aarch64_be-none-linux-gnu/libc/usr/lib"), | ||
| "-B", | ||
| &format!("{cxx_toolchain_dir}/lib/gcc/aarch64_be-none-linux-gnu/14.2.1"), | ||
| ]); |
There was a problem hiding this comment.
So, I got this to work, meaning we can drop the custom linker stuff. I've also reverted the linker change from gcc to g++ for now, it might be needed later but we can change it then.
folkertdev
force-pushed
the
streamline-c-compilation
branch
from
e8d5bc4 to
ff7559f
Compare
|
Lmk if this is still too tough to review btw, I could attempt to break it up further. |
|
LGTM, just resolve those merge conflicts (just version bump for gcc). Also, shouldn't there be a better way to add the libraries than just hardcoding the librarypath, like at least making the version a parameter? |
folkertdev
force-pushed
the
streamline-c-compilation
branch
from
ff7559f to
3735533
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for combining the C files. That is the biggest speedup, so I want to do that first to make later refactorings less painful.