support formatting half open ranges #4044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcartwright
force-pushed
the
half-open-range-syntax
branch
from
123fc01 to
27f2120
Compare
topecongiro
suggested changes
Feb 14, 2020
Contributor
topecongiro
left a comment
topecongiro
left a comment
There was a problem hiding this comment.
Thank you for the PR! LGTM with the comment resolved.
calebcartwright
force-pushed
the
half-open-range-syntax
branch
from
14da660 to
8c43b43
Compare
calebcartwright
force-pushed
the
half-open-range-syntax
branch
from
8c43b43 to
dbf385a
Compare
calebcartwright
commented
Feb 18, 2020
| context, | ||
| ) { | ||
| let missing_comments = match rewrite_missing_comment(comments_span, cond_shape, context) | ||
| { |
Member
Author
Contributor
There was a problem hiding this comment.
Yes, let's keep master green 🍏
Contributor
|
backported in #4105 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for formatting half open range syntax (
X..,..X, and..=X).In #4022 the rustc-ap-* crates were upgraded so that rustfmt will no longer throw a parser error on the half open range syntax, but this PR actually supports formatting those ranges.
Resolves #4009
Refs rust-lang/rust#67264
Refs rust-lang/rust#67258
Refs rust-lang/rust#68120