Skip to content

fix timings order across browsers: 2 #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2021
Merged

fix timings order across browsers: 2 #848

merged 1 commit into from
Mar 4, 2021
+1 −1

Conversation

@klensy
Copy link
Contributor

@klensy klensy commented Mar 4, 2021

Same as #847, but this time order seems work.

@klensy
Copy link
Contributor Author

klensy commented Mar 4, 2021

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort

If compareFunction(a, b) returns less than 0, leave a and b unchanged.
If compareFunction(a, b) returns 0, leave a and b unchanged with respect to each other, but sorted with respect to all different elements. Note: the ECMAScript standard only started guaranteeing this behavior in 2019, thus, older browsers may not respect this.

@Mark-Simulacrum Mark-Simulacrum merged commit 39f0244 into rust-lang:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@klensy @Mark-Simulacrum