Skip to content

Conversation

@ecstatic-morse
Copy link
Contributor

@ecstatic-morse ecstatic-morse commented Mar 29, 2020

This function was obsoleted by find_in_move_path_or_its_descendants.

Fixes #640.

r? @anp

This function was obsoleted by `find_in_move_path_or_its_descendants`.
@anp
Copy link
Contributor

anp commented Mar 29, 2020

LGTM, although now CI is failing for you:

error: The server responded with 404 Not Found for "https://doc.rust-lang.org/nightly/nightly-rustc/rustc/ty/query/config/trait.QueryDescription.html"
── query.md:259:1 ───
 [`self::config::QueryDescription`][QueryDescription]. This trait is
 ^ Server responded with 404 Not Found
Error: ErrorMessage { msg: "One or more incorrect links" }

(EDIT: also note that I don't have write perms, here, probably need someone else to land this)

@JohnTitor
Copy link
Member

We should replace that link with https://doc.rust-lang.org/nightly/nightly-rustc/rustc_query_system/query/config/trait.QueryDescription.html.

r=me once that failure is also fixed.

@tshepang
Copy link
Member

fix for QueryDescription move is #646

@mark-i-m mark-i-m closed this Mar 31, 2020
@tshepang tshepang deleted the ecstatic-morse-patch-1 branch April 1, 2020 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken link to no-longer-extant has_any_child_of

6 participants