Rustdoc: Fix stab disappearing and exclude cfg "doc" and "doctest" #98108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
SpriteOvO
force-pushed
the
doc_auto_cfg-feature-rmv-fix
branch
3 times, most recently
from
e450d7f to
07112a9
Compare
Member
|
Apart from the little nit in the test, looks good to me, thanks! Want to take a look as well @notriddle ? |
SpriteOvO
force-pushed
the
doc_auto_cfg-feature-rmv-fix
branch
from
07112a9 to
72a5673
Compare
notriddle
requested changes
Jun 15, 2022
Contributor
notriddle
left a comment
notriddle
left a comment
There was a problem hiding this comment.
Mostly looks good. Just one little nitpick, then we merge!
SpriteOvO
force-pushed
the
doc_auto_cfg-feature-rmv-fix
branch
from
72a5673 to
713578b
Compare
Contributor
|
@bors r=notriddle,GuillaumeGomez |
Collaborator
|
📌 Commit 713578b has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 15, 2022
…fix, r=notriddle,GuillaumeGomez Rustdoc: Fix stab disappearing and exclude cfg "doc" and "doctest" Fixes rust-lang#98065 Context: rust-lang#43781 (comment) r? `@GuillaumeGomez`
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (392d272): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98065 Context: #43781 (comment)
r? @GuillaumeGomez