rm useless fast_ffi attributes #9766
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is no longer used by the compiler
bors
added a commit
that referenced
this pull request
Oct 8, 2013
this is no longer used by the compiler
Member
|
490 deletions, 0 additions, always a good thing to wake up to |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 29, 2022
The related issue is rust-lang#9766 where the `manual_filter` lint would remove side effects
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 29, 2022
fix manual_filter false positive fixes rust-lang#10088 fixes rust-lang#9766 changelog: FP: [`manual_filter`]: Now ignores if expressions where the else branch has side effects or doesn't return `None` [rust-lang#10091](rust-lang/rust-clippy#10091) <!-- changelog_checked -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is no longer used by the compiler