Improve Rc::new_cyclic and Arc::new_cyclic documentation #95843
Merged
+41
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
the
A-docs
Contributor
|
r? @dtolnay (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
wwylele
reviewed
Apr 9, 2022
This comment has been minimized.
This comment has been minimized.
mejrs
reviewed
Apr 9, 2022
Contributor
mejrs
left a comment
mejrs
left a comment
There was a problem hiding this comment.
Thanks, this api can really use some better explanations ❤️
GuillaumeGomez
force-pushed
the
improve-new-cyclic-doc
branch
from
85fb039 to
87573e9
Compare
mejrs
reviewed
Apr 10, 2022
GuillaumeGomez
force-pushed
the
improve-new-cyclic-doc
branch
from
87573e9 to
e88b181
Compare
Member
|
r? rust-lang/libs |
Member
Author
|
Ping @m-ou-se |
Member
|
Apologies for the delay. Reviewing now. |
m-ou-se
reviewed
May 3, 2022
GuillaumeGomez
force-pushed
the
improve-new-cyclic-doc
branch
from
e88b181 to
f8f7dfa
Compare
rustbot
added
the
T-libs
Member
Author
|
Applied @m-ou-se suggestions and removed the unneeded parts. |
m-ou-se
reviewed
May 3, 2022
GuillaumeGomez
force-pushed
the
improve-new-cyclic-doc
branch
from
f8f7dfa to
cbc40bc
Compare
Member
Author
|
Updated! |
m-ou-se
reviewed
May 4, 2022
GuillaumeGomez
force-pushed
the
improve-new-cyclic-doc
branch
from
cbc40bc to
67d1e7b
Compare
Member
Author
|
Updated! |
Member
|
@bors r+ rollup Thanks for putting up with all my comments. ^^' |
Collaborator
|
📌 Commit 67d1e7b has been approved by |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
Member
Author
|
No problem, they're very welcome! Thanks for putting up with this doc improvement. ;) |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 5, 2022
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#95359 (Update `int_roundings` methods from feedback) - rust-lang#95843 (Improve Rc::new_cyclic and Arc::new_cyclic documentation) - rust-lang#96507 (Suggest calling `Self::associated_function()`) - rust-lang#96635 (Use "strict" mode in JS scripts) - rust-lang#96673 (Report that opaque types are not allowed in impls even in the presence of other errors) - rust-lang#96682 (Show invisible delimeters (within comments) when pretty printing.) - rust-lang#96714 (interpret/validity: debug-check ScalarPair layout information) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95672.
cc @CAD97 (since I used your explanations)