Preserve the Windows GetLastError error in HandleOrInvalid.
#95158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `TryFrom<HandleOrInvalid> for OwnedHandle` and `TryFrom<HandleOrNull> for OwnedHandle` implemenations, `forget` the owned handle on the error path, to avoid calling `CloseHandle` on an invalid handle. It's harmless, except that it may overwrite the thread's `GetLastError` error.
rust-highfive
added
the
S-waiting-on-review
sunfishcode
added a commit
to sunfishcode/io-lifetimes
that referenced
this pull request
Mar 21, 2022
This ports the fix from rust-lang/rust#95158 to io-lifetimes.
Member
|
@bors r+ |
Collaborator
|
📌 Commit 6c407d0 has been approved by |
bors
added
S-waiting-on-bors
sunfishcode
added a commit
to sunfishcode/io-lifetimes
that referenced
this pull request
Mar 21, 2022
This ports the fix from rust-lang/rust#95158 to io-lifetimes.
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (b9c4067): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
TryFrom<HandleOrInvalid> for OwnedHandleandTryFrom<HandleOrNull> for OwnedHandleimplemenations,forgettheowned handle on the error path, to avoid calling
CloseHandleon aninvalid handle. It's harmless, except that it may overwrite the
thread's
GetLastErrorerror.r? @joshtriplett