Skip to content

Use pre-interned symbols in a couple of places #92733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2022
Merged

Use pre-interned symbols in a couple of places #92733

merged 1 commit into from
Jan 10, 2022

Conversation

@bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Jan 10, 2022

No description provided.

@bjorn3 bjorn3 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 10, 2022
@rust-highfive
Copy link
Contributor

rust-highfive commented Jan 10, 2022

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2022
camelid
camelid approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@camelid camelid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@camelid
Copy link
Member

camelid commented Jan 10, 2022

r? @camelid
@bors r+ rollup=iffy (for perf reasons)

@bors
Copy link
Collaborator

bors commented Jan 10, 2022

📌 Commit ec9c949 has been approved by camelid

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2022
@camelid
Copy link
Member

camelid commented Jan 10, 2022

Since the queue is so long:

@bors r-
@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

rust-timer commented Jan 10, 2022

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 10, 2022
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 10, 2022
@camelid
Copy link
Member

camelid commented Jan 10, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 10, 2022

⌛ Trying commit ec9c949 with merge 90e092f69f0d97b05a6d2b6acbde224c898fa9ce...

@bors
Copy link
Collaborator

bors commented Jan 10, 2022

📌 Commit ec9c949 has been approved by camelid

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 10, 2022
@camelid
Copy link
Member

camelid commented Jan 10, 2022

Hmm, looks like bors canceled the try build because I re-r+d. Oh well.

@camelid camelid removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 10, 2022
@bors
Copy link
Collaborator

bors commented Jan 10, 2022

☀️ Test successful - checks-actions
Approved by: camelid
Pushing 90e092f69f0d97b05a6d2b6acbde224c898fa9ce to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 10, 2022
@bors bors merged this pull request into rust-lang:master Jan 10, 2022
@rustbot rustbot added this to the 1.60.0 milestone Jan 10, 2022
@bjorn3 bjorn3 deleted the less_symbol_intern branch January 10, 2022 19:48
@camelid
Copy link
Member

camelid commented Jan 10, 2022 •
edited
Loading

Sorry, bors glitched and the merge commit had to be force-pushed away. Can you open a new PR?

See https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/bors.20merged.20PR.20without.20running.20all.20tests.

@camelid
Copy link
Member

camelid commented Jan 10, 2022 •
edited
Loading

To clarify: while bors says this PR is merged, the merge was un-done so a new PR has to be opened.

@bjorn3 bjorn3 restored the less_symbol_intern branch January 10, 2022 20:14
@bjorn3 bjorn3 mentioned this pull request Jan 10, 2022
Merged
@bjorn3
Copy link
Member Author

bjorn3 commented Jan 10, 2022

Done: #92743

@rust-timer
Copy link
Collaborator

rust-timer commented Jan 10, 2022

Finished benchmarking commit (90e092f69f0d97b05a6d2b6acbde224c898fa9ce): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 14, 2022
@matthiaskrgr
Rollup merge of rust-lang#92743 - bjorn3:less_symbol_intern, r=camelid
0bd6ebe 
Use pre-interned symbols in a couple of places

Re-open of rust-lang#92733 as bors glitched.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 15, 2022
@matthiaskrgr
Rollup merge of rust-lang#92743 - bjorn3:less_symbol_intern, r=camelid
8326f3f 
Use pre-interned symbols in a couple of places

Re-open of rust-lang#92733 as bors glitched.
@bjorn3 bjorn3 deleted the less_symbol_intern branch January 15, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camelid camelid camelid approved these changes

Assignees

@camelid camelid

Labels

C-cleanup Category: PRs that clean code up or issues documenting cleanup. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.60.0

Development

Successfully merging this pull request may close these issues.

7 participants

@bjorn3 @rust-highfive @camelid @bors @rust-timer @petrochenkov @rustbot