Skip to content

Conversation

@cuviper
Copy link
Member

@cuviper cuviper commented Nov 10, 2021

The unstable attribute referenced the closed RFE #38527, so I filed tracking issue #90747.

@rust-highfive
Copy link
Contributor

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 10, 2021
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay
Copy link
Member

dtolnay commented Nov 10, 2021

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 10, 2021

📌 Commit c0fbada has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 10, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 10, 2021
Add a real tracking issue for `CommandExt::groups`

The `unstable` attribute referenced the closed RFE rust-lang#38527, so I filed tracking issue rust-lang#90747.
This was referenced Nov 10, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 10, 2021
…askrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#90690 (kmc-solid: Avoid the use of `asm_const`)
 - rust-lang#90748 (Add a real tracking issue for `CommandExt::groups`)
 - rust-lang#90751 (Update books)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ebd1529 into rust-lang:master Nov 10, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 10, 2021
yanok pushed a commit to yanok/rust that referenced this pull request Nov 10, 2021
…askrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#90690 (kmc-solid: Avoid the use of `asm_const`)
 - rust-lang#90748 (Add a real tracking issue for `CommandExt::groups`)
 - rust-lang#90751 (Update books)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@cuviper cuviper deleted the track-setgroups branch December 8, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants