Specialize Vec::clone_from for Copy types
#87913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should improve performance and reduce code size. This also improves `clone_from` for `String`, `OsString` and `PathBuf`.
Contributor
|
r? @dtolnay (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
dtolnay
requested changes
Aug 10, 2021
Member
dtolnay
left a comment
dtolnay
left a comment
There was a problem hiding this comment.
Looks good. SpecCloneFrom needs to be feature gated on not(no_global_oom_handling) though to fix the failed build.
error[E0599]: no method named `extend_from_slice` found for mutable reference `&mut Vec<T, A>` in the current scopeThis should improve performance and reduce code size.
Would you be able to put together a microbenchmark measuring either of these things?
Contributor
Author
|
Here is a godbolt link for comparison: https://rust.godbolt.org/z/6oGTYs9Ys Specialization removes a branch and a |
dtolnay
approved these changes
Aug 14, 2021
Member
|
@bors r+ |
Collaborator
|
📌 Commit 94d6b22 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve performance and reduce code size.
This also improves
clone_fromforString,OsStringandPathBuf.