Skip to content

Refactor the generation of the metadata for linking #86105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2021
Merged

Refactor the generation of the metadata for linking #86105

merged 1 commit into from
Jul 7, 2021

Conversation

@bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Jun 7, 2021

No description provided.

@bjorn3 bjorn3 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 7, 2021
@rust-highfive
Copy link
Contributor

rust-highfive commented Jun 7, 2021

Some changes occured to rustc_codegen_cranelift

cc @bjorn3

@rust-highfive
Copy link
Contributor

rust-highfive commented Jun 7, 2021

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 7, 2021
@bjorn3 bjorn3 force-pushed the link_info_refactor branch from 1498628 to c3df57e Compare June 7, 2021 16:20
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bjorn3
Copy link
Member Author

bjorn3 commented Jun 7, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

rust-timer commented Jun 7, 2021

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 7, 2021
@bors
Copy link
Collaborator

bors commented Jun 7, 2021

⌛ Trying commit fa21dd12e6bd6c74cb0b96e94933212239944a0a with merge 15f098a756314fabc76b01fc133b3e42a6d4b740...

@bors
Copy link
Collaborator

bors commented Jun 7, 2021

☀️ Try build successful - checks-actions
Build commit: 15f098a756314fabc76b01fc133b3e42a6d4b740 (15f098a756314fabc76b01fc133b3e42a6d4b740)

@rust-timer
Copy link
Collaborator

rust-timer commented Jun 7, 2021

Queued 15f098a756314fabc76b01fc133b3e42a6d4b740 with parent 2312ff1, future comparison URL.

@rust-timer
Copy link
Collaborator

rust-timer commented Jun 7, 2021

Finished benchmarking try commit (15f098a756314fabc76b01fc133b3e42a6d4b740): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 7, 2021
@crlf0710 crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2021
@petrochenkov
Copy link
Contributor

petrochenkov commented Jun 30, 2021

r? @petrochenkov

petrochenkov
petrochenkov reviewed Jun 30, 2021
View reviewed changes
@petrochenkov
Copy link
Contributor

petrochenkov commented Jun 30, 2021

All changes look good to me, but the source of systematic regressions in #86105 (comment) needs to be figured out.

You can break this PR into parts for that and assign them to me, I'll r+ them quickly if they don't cause perf regressions.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2021
@bjorn3 bjorn3 mentioned this pull request Jun 30, 2021
Merged
@bjorn3
Copy link
Member Author

bjorn3 commented Jul 6, 2021

Fixed the nits and also switched from filter_map to plain filter as nothing was mapped anyway.

@petrochenkov
Copy link
Contributor

petrochenkov commented Jul 6, 2021

The function can probably be inlined at this point, it's used only once anyway.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bjorn3 bjorn3 force-pushed the link_info_refactor branch from b7d6da6 to 4cd9808 Compare July 6, 2021 18:02
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bjorn3 bjorn3 force-pushed the link_info_refactor branch from 4cd9808 to 2f52e1c Compare July 7, 2021 12:21
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bjorn3 bjorn3 force-pushed the link_info_refactor branch from 2f52e1c to 445ce86 Compare July 7, 2021 12:47
@petrochenkov
Copy link
Contributor

petrochenkov commented Jul 7, 2021

r=me with squashed commits and green CI.

@bjorn3 bjorn3 force-pushed the link_info_refactor branch from 445ce86 to 2977dff Compare July 7, 2021 13:33
@bjorn3
Copy link
Member Author

bjorn3 commented Jul 7, 2021

Splat

@bors r=petrochenkov

(CI was green when I squashed. I didn't rebase, so the tree is identical.)

@bors
Copy link
Collaborator

bors commented Jul 7, 2021

📌 Commit 2977dff has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 7, 2021
@bors
Copy link
Collaborator

bors commented Jul 7, 2021

⌛ Testing commit 2977dff with merge 5150aa50926afd13216225559fc0e26dcdb7aa51...

@bors
Copy link
Collaborator

bors commented Jul 7, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 7, 2021
@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Jul 7, 2021

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bjorn3
Copy link
Member Author

bjorn3 commented Jul 7, 2021

The dist-aarch64-apple job seems to not have started. This is the full log:

2021-07-07T13:35:42.5693605Z Found online and idle hosted runner(s) in the current repository's organization account that matches the required labels: 'macos-latest'
2021-07-07T13:35:42.5693641Z Waiting for a hosted runner in 'organization' to pick this job...

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2021
@bors
Copy link
Collaborator

bors commented Jul 7, 2021

⌛ Testing commit 2977dff with merge d2b04f0...

@bors
Copy link
Collaborator

bors commented Jul 7, 2021

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing d2b04f0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 7, 2021
@bors bors merged commit d2b04f0 into rust-lang:master Jul 7, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 7, 2021
@bjorn3 bjorn3 deleted the link_info_refactor branch March 14, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels

C-cleanup Category: PRs that clean code up or issues documenting cleanup. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.55.0

Development

Successfully merging this pull request may close these issues.

9 participants

@bjorn3 @rust-highfive @rust-log-analyzer @rust-timer @bors @petrochenkov @crlf0710 @jackh726 @rustbot