Skip to content

CTFE get_alloc_extra_mut: also provide ref to MemoryExtra #85578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2021
Merged

CTFE get_alloc_extra_mut: also provide ref to MemoryExtra #85578

merged 1 commit into from
May 22, 2021

Conversation

@RalfJung
Copy link
Member

@RalfJung RalfJung commented May 22, 2021

This would let me use mutable references in more places in Stacked Borrows, avoiding some RefCell overhead. :)

r? @oli-obk

@rust-highfive
Copy link
Contributor

rust-highfive commented May 22, 2021

Some changes occured to the CTFE / Miri engine

cc @rust-lang/miri

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 22, 2021
@oli-obk
Copy link
Contributor

oli-obk commented May 22, 2021

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 22, 2021

📌 Commit 96ae300 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 22, 2021
@bors
Copy link
Collaborator

bors commented May 22, 2021

⌛ Testing commit 96ae300 with merge e4ca166...

@bors
Copy link
Collaborator

bors commented May 22, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing e4ca166 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 22, 2021
@bors bors merged commit e4ca166 into rust-lang:master May 22, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 22, 2021
@rust-highfive rust-highfive mentioned this pull request May 22, 2021
Closed
@rust-highfive
Copy link
Contributor

rust-highfive commented May 22, 2021

📣 Toolstate changed by #85578!

Tested on commit e4ca166.
Direct link to PR: #85578

💔 miri on windows: test-pass → build-fail (cc @RalfJung @oli-obk @eddyb).
💔 miri on linux: test-pass → build-fail (cc @RalfJung @oli-obk @eddyb).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request May 22, 2021
@rust-highfive
📣 Toolstate changed by rust-lang/rust#85578!
0c58bd1 
Tested on commit rust-lang/rust@e4ca166.
Direct link to PR: <rust-lang/rust#85578>

💔 miri on windows: test-pass → build-fail (cc @RalfJung @oli-obk @eddyb).
💔 miri on linux: test-pass → build-fail (cc @RalfJung @oli-obk @eddyb).
@RalfJung RalfJung deleted the alloc-mem-extra branch May 23, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oli-obk oli-obk

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.54.0

Development

Successfully merging this pull request may close these issues.

5 participants

@RalfJung @rust-highfive @oli-obk @bors @rustbot