Skip to content

Remove unneeded type resolving #83839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2021
Merged

Remove unneeded type resolving #83839

merged 2 commits into from
Apr 4, 2021

Conversation

@ldm0
Copy link
Contributor

@ldm0 ldm0 commented Apr 4, 2021

small optimization.

@rust-highfive
Copy link
Contributor

rust-highfive commented Apr 4, 2021

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 4, 2021
@petrochenkov
Copy link
Contributor

petrochenkov commented Apr 4, 2021

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 4, 2021

📌 Commit 3982ac2 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2021
@petrochenkov
Copy link
Contributor

petrochenkov commented Apr 4, 2021 •
edited
Loading

Hmm, looks like only_has_type is used pretty commonly, so this may have a detectable effect on performance.

@petrochenkov
Copy link
Contributor

petrochenkov commented Apr 4, 2021

@bors rollup=never

@bors
Copy link
Collaborator

bors commented Apr 4, 2021

⌛ Testing commit 3982ac2 with merge b1ea261...

@bors
Copy link
Collaborator

bors commented Apr 4, 2021

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing b1ea261 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 4, 2021
@bors bors merged commit b1ea261 into rust-lang:master Apr 4, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 4, 2021
@ldm0 ldm0 deleted the deref branch April 4, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@henryboisdequin henryboisdequin henryboisdequin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@petrochenkov petrochenkov

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.53.0

Development

Successfully merging this pull request may close these issues.

6 participants

@ldm0 @rust-highfive @petrochenkov @bors @henryboisdequin @rustbot