Skip to content

Conversation

@RalfJung
Copy link
Member

@RalfJung RalfJung commented Feb 18, 2021

Fixes Miri breakage (no issue was created as the toolstate tracking is currently broken: #82254)

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 18, 2021
@RalfJung
Copy link
Member Author

Cc @rust-lang/miri
@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Feb 18, 2021

📌 Commit cf76a5cfac37ee7e7ca8b915cf3db92604bba29c has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2021
@bors
Copy link
Collaborator

bors commented Feb 18, 2021

⌛ Testing commit cf76a5cfac37ee7e7ca8b915cf3db92604bba29c with merge 9d26aefaf34d018bead30d6cd3365ad2d8353bb5...

@RalfJung
Copy link
Member Author

#82124 will break Miri again so landing this is rather pointless...
@bors r- retry

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 18, 2021
@rust-log-analyzer

This comment has been minimized.

@RalfJung
Copy link
Member Author

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Feb 20, 2021

📌 Commit 3b81b47 has been approved by RalfJung

@bors
Copy link
Collaborator

bors commented Feb 21, 2021

⌛ Testing commit 3b81b47 with merge a31c162...

@bors
Copy link
Collaborator

bors commented Feb 21, 2021

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing a31c162 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 21, 2021
@bors bors merged commit a31c162 into rust-lang:master Feb 21, 2021
@rustbot rustbot added this to the 1.52.0 milestone Feb 21, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
  CACHE_DOMAIN: ci-caches.rust-lang.org
  TOOLSTATE_REPO_ACCESS_TOKEN: ***
##[endgroup]
Cloning into 'rust-toolstate'...
/home/runner/work/rust/rust/src/tools/publish_toolstate.py:121: DeprecationWarning: 'U' mode is deprecated
📣 Toolstate changed by rust-lang/rust#82253!

Tested on commit rust-lang/rust@a31c16212d70fcae3ad9d073b00d883951e573ee.
Direct link to PR: <https://github.com/rust-lang/rust/pull/82253>

🎉 miri on windows: test-fail → test-pass (cc @eddyb @RalfJung @oli-obk).
🎉 miri on linux: test-fail → test-pass (cc @eddyb @RalfJung @oli-obk).

  with open(path, 'rU') as f:
Traceback (most recent call last):
  File "/home/runner/work/rust/rust/src/tools/publish_toolstate.py", line 338, in <module>
    response = urllib2.urlopen(urllib2.Request(
  File "/usr/lib/python3.8/urllib/request.py", line 222, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib/python3.8/urllib/request.py", line 522, in open
    req = meth(req)
  File "/usr/lib/python3.8/urllib/request.py", line 1281, in do_request_
    raise TypeError(msg)
TypeError: POST data should be bytes, an iterable of bytes, or a file object. It cannot be of type str.
##[error]Process completed with exit code 1.

@RalfJung RalfJung deleted the miri branch February 21, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants